-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gossip_map): add gossip_map implementation #55
Merged
vincenzopalazzo
merged 12 commits into
laanwj:master
from
vincenzopalazzo:macros/gossip_map
Jul 26, 2024
Merged
feat(gossip_map): add gossip_map implementation #55
vincenzopalazzo
merged 12 commits into
laanwj:master
from
vincenzopalazzo:macros/gossip_map
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
September 25, 2022 17:33
b5354d7
to
982516f
Compare
vincenzopalazzo
changed the title
feat(gossip_mapp): add gossip_map implementation
feat(gossip_map): add gossip_map implementation
Oct 19, 2022
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
May 6, 2023 10:00
982516f
to
a8c4382
Compare
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
June 1, 2023 11:07
839aa2c
to
a3b382f
Compare
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
June 13, 2023 10:00
a3b382f
to
ef60de4
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
March 27, 2024 19:20
ef60de4
to
a708a29
Compare
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
July 26, 2024 17:10
2d34e2e
to
650e672
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
This is a change for the gossip map that use a compiler that generate the messages that are used inside the gossip map. Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
The code generation is buggy because it decode a single byte with a Bitfield and then some type in the lightning network are decoded as [u8; 3]; This mean that the Bitfield should be able to skip the leng encoding, or semplify the implementation by having a type that is without size. Signed-off-by: Vincenzo Palazzo <[email protected]>
A lightning network message is a chunk of memory, and when a single stream contains more than a single message it is required split this by chunk. This commit is implementing the following logic Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/gossip_map
branch
from
July 26, 2024 17:21
4c651e7
to
3892bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still in its infancy, but this will enable us to work directly with the gossip map of cln in rust.
cc @rustyrussell
Docs: ElementsProject/lightning@6e4e104
Signed-off-by: Vincenzo Palazzo [email protected]