Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gossip_map): add gossip_map implementation #55

Merged
merged 12 commits into from
Jul 26, 2024

Conversation

vincenzopalazzo
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo commented Sep 19, 2022

This PR is still in its infancy, but this will enable us to work directly with the gossip map of cln in rust.

cc @rustyrussell

Docs: ElementsProject/lightning@6e4e104

Signed-off-by: Vincenzo Palazzo [email protected]

@vincenzopalazzo vincenzopalazzo changed the title feat(gossip_mapp): add gossip_map implementation feat(gossip_map): add gossip_map implementation Oct 19, 2022
@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review July 26, 2024 17:20
This is a change for the gossip map that use a compiler
that generate the messages that are used inside the gossip
map.

Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
The code generation is buggy because it decode
a single byte with a Bitfield and then some type
in the lightning network are decoded as [u8; 3];

This mean that the Bitfield should be able to skip the leng
encoding, or semplify the implementation by having a type
that is without size.

Signed-off-by: Vincenzo Palazzo <[email protected]>
A lightning network message is a chunk of memory, and when
a single stream contains more than a single message it is
required split this by chunk.

This commit is implementing the following logic

Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo merged commit 143a30e into laanwj:master Jul 26, 2024
5 checks passed
@vincenzopalazzo vincenzopalazzo deleted the macros/gossip_map branch July 26, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant